Skip to content

[PW_SID:969572] [v2] crypto: riscv/poly1305 - import OpenSSL/CRYPTOGAMS implementation#485

Closed
linux-riscv-bot wants to merge 2 commits into
workflowfrom
pw969572
Closed

[PW_SID:969572] [v2] crypto: riscv/poly1305 - import OpenSSL/CRYPTOGAMS implementation#485
linux-riscv-bot wants to merge 2 commits into
workflowfrom
pw969572

Conversation

@linux-riscv-bot

@linux-riscv-bot linux-riscv-bot commented Jun 8, 2025

Copy link
Copy Markdown

PR for series 969572 applied to workflow

Name: [v2] crypto: riscv/poly1305 - import OpenSSL/CRYPTOGAMS implementation
URL: https://patchwork.kernel.org/project/linux-riscv/list/?series=969572
Version: 2

Linux RISC-V bot and others added 2 commits June 7, 2025 19:16
Adding CI files
b94890f
@BattiestStone4
crypto: riscv/poly1305 - import OpenSSL/CRYPTOGAMS implementation
a0795ee 
This is a straight import of the OpenSSL/CRYPTOGAMS Poly1305
implementation for riscv authored by Andy Polyakov.
The file 'poly1305-riscv.pl' is taken straight from this upstream
GitHub repository [0] at commit 33fe84bc21219a16825459b37c825bf4580a0a7b,
and this commit fixed a bug in riscv 64bit implementation.

[0] https://github.com/dot-asm/cryptogams

Signed-off-by: Zhihang Shao <zhihang.shao.iscas@gmail.com>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@linux-riscv-bot

linux-riscv-bot commented Jun 8, 2025

Copy link
Copy Markdown
Author

Patch 1: "[v2] crypto: riscv/poly1305 - import OpenSSL/CRYPTOGAMS implementation"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 109.93 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Jun 8, 2025

Copy link
Copy Markdown
Author

Patch 1: "[v2] crypto: riscv/poly1305 - import OpenSSL/CRYPTOGAMS implementation"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1086.27 seconds
Result: ERROR
Output:

Redirect to /build/tmp.yEGwqFZbb3 and /build/tmp.KjUqgkoK94
Tree base:
b94890f0e21a7 ("Adding CI files")
Building the whole tree with the patch
Building the tree before the patch
Building the tree with the patch
New errors added:
--- /build/tmp.9GYEe02Ey7	2025-06-08 13:59:31.625020808 +0000
+++ /build/tmp.Gox0Q70a7E	2025-06-08 13:59:31.640020672 +0000
@@ -518,0 +519 @@
+      1 arch/riscv/lib/crypto/poly1305-glue.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing
Per-file breakdown
error/warning file pre:
error/warning file post:
pre: 4984 post: 4985



real	15m5.787s
user	569m5.714s
sys	109m34.153s

real	1m27.634s
user	3m28.615s
sys	2m6.604s

real	1m23.114s
user	2m56.267s
sys	2m0.396s

@linux-riscv-bot

linux-riscv-bot commented Jun 8, 2025

Copy link
Copy Markdown
Author

Patch 1: "[v2] crypto: riscv/poly1305 - import OpenSSL/CRYPTOGAMS implementation"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1590.50 seconds
Result: ERROR
Output:

Redirect to /build/tmp.lW6dzKDnVG and /build/tmp.YYCnvj4ZQV
Tree base:
b94890f0e21a7 ("Adding CI files")
Building the whole tree with the patch
Building the tree before the patch
Building the tree with the patch
New errors added:
--- /build/tmp.2NWRavoC5W	2025-06-08 14:26:03.233792159 +0000
+++ /build/tmp.RE7UaQrnkW	2025-06-08 14:26:03.241792093 +0000
@@ -518,0 +519 @@
+      1 arch/riscv/lib/crypto/poly1305-glue.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing
Per-file breakdown
error/warning file pre:
pre: 4984 post: 4985



real	20m48.916s
user	749m51.730s
sys	128m32.317s

real	2m49.556s
user	4m48.245s
sys	2m1.084s

real	2m41.941s
user	4m2.496s
sys	1m53.658s

@linux-riscv-bot

linux-riscv-bot commented Jun 8, 2025

Copy link
Copy Markdown
Author

Patch 1: "[v2] crypto: riscv/poly1305 - import OpenSSL/CRYPTOGAMS implementation"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 23.94 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Jun 8, 2025

Copy link
Copy Markdown
Author

Patch 1: "[v2] crypto: riscv/poly1305 - import OpenSSL/CRYPTOGAMS implementation"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 25.03 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Jun 8, 2025

Copy link
Copy Markdown
Author

Patch 1: "[v2] crypto: riscv/poly1305 - import OpenSSL/CRYPTOGAMS implementation"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 1501.19 seconds
Result: WARNING
Output:

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#71: 
new file mode 100644

CHECK: Lines should not end with a '('
#92: FILE: arch/riscv/lib/crypto/poly1305-glue.c:17:
+asmlinkage void poly1305_block_init_arch(

WARNING: adding a line without newline at end of file
#130: FILE: arch/riscv/lib/crypto/poly1305-glue.c:55:
+MODULE_LICENSE("GPL");

total: 0 errors, 2 warnings, 1 checks, 893 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Commit a0795eee954a ("crypto: riscv/poly1305 - import OpenSSL/CRYPTOGAMS implementation") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.
total: 0 errors, 2 warnings, 1 checks, 893 lines checked
CHECK: Lines should not end with a '('
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
WARNING: adding a line without newline at end of file

@linux-riscv-bot

linux-riscv-bot commented Jun 8, 2025

Copy link
Copy Markdown
Author

Patch 1: "[v2] crypto: riscv/poly1305 - import OpenSSL/CRYPTOGAMS implementation"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 71.64 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Jun 8, 2025

Copy link
Copy Markdown
Author

Patch 1: "[v2] crypto: riscv/poly1305 - import OpenSSL/CRYPTOGAMS implementation"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.22 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Jun 8, 2025

Copy link
Copy Markdown
Author

Patch 1: "[v2] crypto: riscv/poly1305 - import OpenSSL/CRYPTOGAMS implementation"
kdoc
Desc: Detects for kdoc errors
Duration: 0.90 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Jun 8, 2025

Copy link
Copy Markdown
Author

Patch 1: "[v2] crypto: riscv/poly1305 - import OpenSSL/CRYPTOGAMS implementation"
module-param
Desc: Detect module_param changes
Duration: 0.24 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Jun 8, 2025

Copy link
Copy Markdown
Author

Patch 1: "[v2] crypto: riscv/poly1305 - import OpenSSL/CRYPTOGAMS implementation"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.22 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Jun 8, 2025

Copy link
Copy Markdown
Author

Patch 1: "[v2] crypto: riscv/poly1305 - import OpenSSL/CRYPTOGAMS implementation"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.29 seconds
Result: PASS

@linux-riscv-bot
linux-riscv-bot force-pushed the workflow branch 2 times, most recently from e82ef7c to e65aa72 Compare June 8, 2025 21:17
@linux-riscv-bot
linux-riscv-bot deleted the pw969572 branch June 9, 2025 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@linux-riscv-bot @BattiestStone4